From e19b3e3466409270045e42bde2974bf338866d0a Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Wed, 1 Mar 2017 04:31:09 +0300 Subject: [PATCH] more notes... Signed-off-by: Alex A. Naanou --- ui (gen4)/features/peer.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ui (gen4)/features/peer.js b/ui (gen4)/features/peer.js index d1fc8034..e3d273a5 100755 --- a/ui (gen4)/features/peer.js +++ b/ui (gen4)/features/peer.js @@ -314,6 +314,8 @@ var ChildProcessPeerActions = actions.Actions({ resolve(id) }).bind(this)) })], + // XXX should this call .stop() on the child??? + // ...does the child handle kill gracefully??? peerDisconnect: ['- Peer/', makeProtocolHandler('child', function(id){ return new Promise((function(resolve, reject){ @@ -330,6 +332,10 @@ var ChildProcessPeerActions = actions.Actions({ }).bind(this)) })], + // XXX can we do sync??? + // ...this would be useful to 100% match the action api and + // make the thing transparent... + // XXX can we do prop access??? peerCall: ['- Peer/', makeProtocolHandler('child', function(id, action){ return new Promise((function(resolve, reject){