flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 02:40:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed menu browseMode caching...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2018-03-26 13:28:25 +03:00
parent fb0fed655d
commit e64d002ad8
1 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
ui (gen4)/features/ui-widgets.js
View File

@ -1614,10 +1614,6 @@ var BrowseActionsActions = actions.Actions({
return cur return cur
}], }],
// XXX do not draw empty dirs (i.e. where all actions are hidden)...
// Example:
// /Store/
// /Jobs/
// XXX can we do a deep search on '/' -- find any nested action??? // XXX can we do a deep search on '/' -- find any nested action???
// ...or rather a search from this level and down... // ...or rather a search from this level and down...
// XXX can this also do a flat mode??? // XXX can this also do a flat mode???
@ -1735,16 +1731,31 @@ var BrowseActionsActions = actions.Actions({
return (keys[action] || []).join(' / ') } return (keys[action] || []).join(' / ') }
// Get action browse mode (disabled or hidden)... // Get action browse mode (disabled or hidden)...
//
// NOTE: this will cache and reuse action's browseMode, this
// will make things faster when lots of actions use the
// same mode test (alias)...
var mode_cache = {} var mode_cache = {}
var getMode = function(action){ var getMode = function(action){
var m = action var m = action
var visited = [m] var visited = [m]
var last var last
// check cache...
if(m in (mode_cache || {})){
return mode_cache[m]
}
// handle aliases... // handle aliases...
do { do {
last = m last = m
m = actions.getActionAttr(m, 'browseMode') m = actions.getActionAttr(m, 'browseMode')
// check cache...
if(m in (mode_cache || {})){
return mode_cache[m]
}
// check for loops... // check for loops...
if(m && visited[m] != null){ if(m && visited[m] != null){
m = null m = null
@ -1755,11 +1766,16 @@ var BrowseActionsActions = actions.Actions({
//return m ? m.call(actions) : undefined //return m ? m.call(actions) : undefined
return m ? return m ?
// no cache...
(mode_cache == null ? (mode_cache == null ?
m.call(actions) m.call(actions)
// cache hit...
: last in mode_cache ? : last in mode_cache ?
mode_cache[last] mode_cache[last]
: (mode_cache[last] = m.call(actions))) // call check and populate cache...
: (mode_cache[action] =
mode_cache[last] =
m.call(actions)))
: undefined : undefined
} }