mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-12-16 16:21:40 +00:00
some cleanup...
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
446725ddbf
commit
ebbb5399c7
@ -116,7 +116,7 @@ Roadmap
|
|||||||
| - adjacent ribbon is not moving
|
| - adjacent ribbon is not moving
|
||||||
|
|
|
|
||||||
| effect:
|
| effect:
|
||||||
| - previews get reloaded
|
| - previews get reloaded/redrawn
|
||||||
|
|
|
|
||||||
| expected:
|
| expected:
|
||||||
| - all unmoving ribbons remain static
|
| - all unmoving ribbons remain static
|
||||||
|
|||||||
@ -98,7 +98,7 @@ function setupDataBindings(viewer){
|
|||||||
// NOTE: we are accounting for position relative to image...
|
// NOTE: we are accounting for position relative to image...
|
||||||
// NOTE: we do not need to account for image height because
|
// NOTE: we do not need to account for image height because
|
||||||
// of origin and vertical-align... (check)
|
// of origin and vertical-align... (check)
|
||||||
// XXX also check for visibility...
|
// XXX also check for visibility... (???)
|
||||||
var R = $('.viewer').height()/2
|
var R = $('.viewer').height()/2
|
||||||
var d = Math.abs(getRelativeVisualPosition(image, ribbon).top)
|
var d = Math.abs(getRelativeVisualPosition(image, ribbon).top)
|
||||||
if( d >= R ){
|
if( d >= R ){
|
||||||
@ -190,13 +190,11 @@ function setupDataBindings(viewer){
|
|||||||
.on('requestedFirstImage', function(evt, ribbon){
|
.on('requestedFirstImage', function(evt, ribbon){
|
||||||
var r = getRibbonIndex(ribbon)
|
var r = getRibbonIndex(ribbon)
|
||||||
var gr = DATA.ribbons[r]
|
var gr = DATA.ribbons[r]
|
||||||
console.log('!!!!! rolling to first:', r)
|
|
||||||
rollImages(-gr.length, ribbon)
|
rollImages(-gr.length, ribbon)
|
||||||
})
|
})
|
||||||
.on('requestedLastImage', function(evt, ribbon){
|
.on('requestedLastImage', function(evt, ribbon){
|
||||||
var r = getRibbonIndex(ribbon)
|
var r = getRibbonIndex(ribbon)
|
||||||
var gr = DATA.ribbons[r]
|
var gr = DATA.ribbons[r]
|
||||||
console.log('!!!!! rolling to last:', r)
|
|
||||||
rollImages(gr.length, ribbon)
|
rollImages(gr.length, ribbon)
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user