flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

moved link detach responsebility to the link itself...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2021-02-11 02:43:24 +03:00
parent 2680a6160a
commit efb0c247ae
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Viewer/features/core.js
View File

@ -3103,7 +3103,7 @@ var TaskActions = actions.Actions({
// XXX is peer stuff just a special context??? // XXX is peer stuff just a special context???
// ...feels like yes // ...feels like yes
// XXX is context manager a special case of task manager??? // XXX is context manager a special case of task manager???
// XXX move to a separate feature... // XXX move to a separate feature... (???)
__contexts: null, __contexts: null,
get contexts(){}, get contexts(){},
@ -3132,8 +3132,6 @@ var TaskActions = actions.Actions({
// Links... // Links...
// //
// NOTE: all links to current state in .links will be detached on .clear() // NOTE: all links to current state in .links will be detached on .clear()
//
// XXX after this is stabilized, do we need session tasks and its complexities???
__links: null, __links: null,
get links(){ get links(){
var links = this.__links = this.__links || {} var links = this.__links = this.__links || {}
@ -3146,6 +3144,9 @@ var TaskActions = actions.Actions({
return links }, return links },
get linked(){ get linked(){
return this.link() }, return this.link() },
// XXX go through ImageGrid instance data and re-check what needs to
// be cloned...
// XXX should this be a constructor???
link: ['- System/', link: ['- System/',
doc`Get/create links... doc`Get/create links...
@ -3228,7 +3229,15 @@ var TaskActions = actions.Actions({
// link configuration... // link configuration...
logger: that.logger logger: that.logger
.push(`Linked ${ Object.keys(links).length }`), .push(`Linked ${ Object.keys(links).length }`),
})) }], })
// detach link on parent .clear(..)...
.run(function(){
var link = this
that.one('clear.pre', function(){
// NOTE: we are doing a partial detach here as the
// parent is overwriting its data and we do not
// need to clone it...
link.detachLink(false) }) })) }],
// XXX would be nice to have an ability to partially clone the instance... // XXX would be nice to have an ability to partially clone the instance...
@ -3241,6 +3250,7 @@ var TaskActions = actions.Actions({
__isolated: null, __isolated: null,
get isolated(){ get isolated(){
return (this.__isolated = this.__isolated || []) }, return (this.__isolated = this.__isolated || []) },
// XXX should this be a constructor???
isolate: ['- System/', isolate: ['- System/',
function(){ function(){
var clones = this.isolated var clones = this.isolated
@ -3271,19 +3281,6 @@ module.Tasks = ImageGridFeatures.Feature({
// stop session tasks... // stop session tasks...
['clear', ['clear',
'sessionTasks.abort'], 'sessionTasks.abort'],
// detach links to current state...
['clear.pre',
function(){
var that = this
Object.values(this.links || [])
.forEach(function(link){
// only detach links to current state...
link.data === that.data
&& link.images === that.images
// NOTE: we do a partial detach here as .clear(..) will
// detach the data for us...
&& link.detachLink(false) }) }],
], ],
}) })