From f099aa68e0b607e71dd7f0755c9589f4e6e05987 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Wed, 30 Dec 2020 16:54:23 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- Viewer/features/core.js | 11 ++--------- Viewer/features/metadata.js | 3 +++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/Viewer/features/core.js b/Viewer/features/core.js index 2485bb44..7e309331 100755 --- a/Viewer/features/core.js +++ b/Viewer/features/core.js @@ -3170,8 +3170,7 @@ module.Tasks = ImageGridFeatures.Feature({ var selfTest = module.selfTest = function(func){ func.__self_test__ = true - return func -} + return func } var SelfTestActions = actions.Actions({ config: { @@ -3188,19 +3187,13 @@ var SelfTestActions = actions.Actions({ return action != 'selfTest' && (that[action].func.__self_test__ || that.getActionAttr(action, 'self_test'))}) - logger && tests.forEach(function(action){ logger.emit('found', action) }) - - tests.forEach(function(action){ that[action]() - logger - && logger.emit('done', action) - }) - })], + && logger.emit('done', action) }) })], }) var SelfTest = diff --git a/Viewer/features/metadata.js b/Viewer/features/metadata.js index eefb5dcd..48d0f648 100755 --- a/Viewer/features/metadata.js +++ b/Viewer/features/metadata.js @@ -187,6 +187,9 @@ var MetadataReaderActions = actions.Actions({ && that.markChanged('images', [gid]) } resolve(data) }) }) }) })], + // XXX Q: should this be a linked task??? + // ...on one hand yes, on the other, saving after this may + // unintentionally save other state from the main object... readAllMetadata: ['File/Read all metadata', 'readMetadata: "all" ...'],