flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-31 03:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor bugfix...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2012-08-22 21:46:37 +04:00
parent 54a4998378
commit f15ba9ed16
3 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui/TODO.otl
View File

@ -123,7 +123,7 @@ Priority work
[X] 100% actions [X] 100% actions
[X] bug: shifting up to new ribbon pushes the current row down... [X] bug: shifting up to new ribbon pushes the current row down...
| before starting on a fix, need to cleanup the code from old hacks and workarounds... | before starting on a fix, need to cleanup the code from old hacks and workarounds...
[_] 24% Preview II (optional features) [_] 29% Preview II (optional features)
[_] 0% PhoneGap + Android Issues: [_] 0% PhoneGap + Android Issues:
[_] half the keyboard is not working... [_] half the keyboard is not working...
[_] screen buttons are very laggy [_] screen buttons are very laggy
@ -173,6 +173,20 @@ Priority work
[_] double tap/click to zoom (a-la iPad) [_] double tap/click to zoom (a-la iPad)
| fit <-> actual pixels (max) | fit <-> actual pixels (max)
[_] pinch to zoom [_] pinch to zoom
[X] BUG: rendering error when current ribbon images opacity is 1...
| This happens when:
| - opcity of .current.ribbon .image is 1
| - there is atleast a ribbon above
| - the view is zoomed-out a bit ~70%
|
| the view is partially re-rendered when navigating images...
|
| since this is a browser render error, think of a way to work
| around this.
|
| WORKAROUND: set the opacity to 0.9999 instead of 1 forces the
| browser to re-render the whole set correctly. need to find a
| better way...
[X] 100% add sort/re-sort capability... [X] 100% add sort/re-sort capability...
[X] abstract out image id [X] abstract out image id
[X] replace id (use something else like filename) [X] replace id (use something else like filename)

10
ui/gallery-prototype.js
View File

@ -875,6 +875,16 @@ function setupControlElements(){
// NOTE: when the images are loaded, the actual handlers will be set by the loader... // NOTE: when the images are loaded, the actual handlers will be set by the loader...
setupImageEventHandlers($(".image")) setupImageEventHandlers($(".image"))
// make the indicator active...
$(".current-indicator div")
.click(function(){
$('.current.image').click()
})
.dblclick(function(){
ImageGrid.toggleSingleImageMode()
})
// buttons... // buttons...
$('.screen-button.next-image').mousedown(ImageGrid.nextImage) $('.screen-button.next-image').mousedown(ImageGrid.nextImage)
$('.screen-button.prev-image').mousedown(ImageGrid.prevImage) $('.screen-button.prev-image').mousedown(ImageGrid.prevImage)

9
ui/gallery.css
View File

@ -120,12 +120,14 @@
.current-indicator { .current-indicator {
display: none; display: none;
cursor: hand;
} }
.opaque-current-ribbon .current-indicator { .opaque-current-ribbon .current-indicator {
display: block; display: block;
position: absolute; position: absolute;
z-index: 1000;
} }
.opaque-current-ribbon .current-indicator div { .opaque-current-ribbon .current-indicator div {
position: relative; position: relative;
@ -136,6 +138,8 @@
width: 100%; width: 100%;
height: 100%; height: 100%;
cursor: hand;
} }
.opaque-current-ribbon.dot-indicator .current-indicator { .opaque-current-ribbon.dot-indicator .current-indicator {
@ -154,7 +158,10 @@
} }
.opaque-current-ribbon .current.ribbon .image { .opaque-current-ribbon .current.ribbon .image {
opacity: 1.0; /* XXX this should actiually be 1.0, but that makes the webkit
* renderer misbehave, so this is a workaround
*/
opacity: 0.9999;
} }