flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-30 10:50:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleaenup...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2020-02-02 05:33:47 +03:00
parent 2eb9718fdb
commit f44d998f00
1 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ui (gen4)/features/ui-widgets.js
View File

@ -1227,9 +1227,6 @@ function(title, options){
: 'off' } }))) } : 'off' } }))) }
//
// XXX BUG: if user passes a new spec each time this will not work...
// XXX still needs work...
browse.items.batch = browse.items.batch =
function(spec, callback){ function(spec, callback){
var that = this var that = this
@ -1251,7 +1248,6 @@ function(spec, callback){
// other... // other...
: that(field) }) : that(field) })
// batch callback... // batch callback...
var __v = Date.now()
var cb var cb
callback callback
&& this.dialog && this.dialog
@ -1259,7 +1255,6 @@ function(spec, callback){
// multiple times... // multiple times...
// ...change to .close(..) when fixed... // ...change to .close(..) when fixed...
.one('close', cb = function(mode){ .one('close', cb = function(mode){
console.log('callback:', __v)
// XXX get the field data and pass it to the callback... // XXX get the field data and pass it to the callback...
callback( callback(
// get the field-value pairs... // get the field-value pairs...
@ -1279,27 +1274,8 @@ function(spec, callback){
// XXX is this the right spot for this??? // XXX is this the right spot for this???
mode) }) mode) })
// reset the callback on update... // reset the callback on update...
// XXX this does not work yet...
// there seems to be two problems here:
// - 'update' is triggered on first draw, thus
// triggering .off(..)... (CONFIRMED)
// ...this should lead to the callback(..) not
// being called at all -- see next issue...
// - .off(..) for some reason does not work... (CONFIRMED)
// ...are we off-ing the right source???
// ...one possible cause of this is that .one(..) is actually
// binding a wrapper and not the original function -- CONFIRMED!
// ...to reproduce:
// var f = function(){ console.log('MOO!!!') }
// ig.modal.client
// .one('moo', f)
// .off('moo', f)
// .trigger('moo') // -> will call f(..)
.one('update', function(){ .one('update', function(){
console.log('update:', __v)
// XXX BUG? this.off(..) will not work with non-standard events...
this.dom.off('close', cb) }) this.dom.off('close', cb) })
&& console.log('batch:', __v)
return this } return this }