From f69837c625128e6ed1b199277475a33a1ac80c21 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Wed, 19 Jun 2019 01:14:13 +0300
Subject: [PATCH] tweaking cut/compy/paste + added menu handling...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 ui (gen4)/lib/widget/browse2.html |  7 +++++--
 ui (gen4)/lib/widget/browse2.js   | 32 +++++++++++++++----------------
 2 files changed, 21 insertions(+), 18 deletions(-)

diff --git a/ui (gen4)/lib/widget/browse2.html b/ui (gen4)/lib/widget/browse2.html
index 5f21a60a..b3aea9f2 100755
--- a/ui (gen4)/lib/widget/browse2.html	
+++ b/ui (gen4)/lib/widget/browse2.html	
@@ -196,13 +196,16 @@ requirejs([
 		make(['list', 'of', 'text'])
 		make.group(
 			make('$group item 0', 
-				function(){ console.log('###', ...arguments) }),
+				function(){ console.log('##', ...arguments) }),
 			'group item 1 (bare)')
 		// XXX Q: should we show only one if multiple lines are in sequence???
 		make('---')
 		// embeded browser...
 		make(browser.Browser(function(make){
-			make('inlined browser item 0')
+			make('inlined browser item 0', {
+				open: function(){ console.log('!!! OPEN', ...arguments) },
+				menu: function(){ console.log('!!! MENU', ...arguments) },
+			})
 			make(1)
 			make(2)
 		}))
diff --git a/ui (gen4)/lib/widget/browse2.js b/ui (gen4)/lib/widget/browse2.js
index e0369a82..ac2cf9bb 100755
--- a/ui (gen4)/lib/widget/browse2.js	
+++ b/ui (gen4)/lib/widget/browse2.js	
@@ -3310,7 +3310,10 @@ var BrowserPrototype = {
 			: object.parent(BrowserPrototype.get, this).call(this, pattern, func, ...args) },
 
 
-	// A hack to get user pasted text...
+	// DOM/UI Helpers...
+	//
+	// NOTE: not for direct use...
+	// NOTE: both of these feel hackish...
 	__paste: function(callback){
 		var focus = this.dom.querySelector(':focus') || this.dom
 
@@ -3336,9 +3339,12 @@ var BrowserPrototype = {
 				: this.load(str) 
 		}.bind(this), 5)
 	},
-	// XXX should we query navigator.permissions???
 	__copy: function(text){
-		navigator.clipboard.writeText(text || this.path) },
+		navigator.permissions.query({name: 'clipboard-write'})
+			.then(function({state}){
+				;(state == 'granted' || state == 'prompt' ) ?
+					navigator.clipboard.writeText(text || this.path) 
+					: console.warn('.__copy(..): clipboard-write not allowed.') }) },
 
 	// Element renderers...
 	//
@@ -3356,7 +3362,6 @@ var BrowserPrototype = {
 	// 		</div>
 	// 	or same as .renderList(..)
 	//
-	// XXX revise...
 	renderFinalize: function(items, context){
 		var that = this
 		var d = this.renderList(items, context)
@@ -3660,17 +3665,20 @@ var BrowserPrototype = {
 				// 		already focused...
 				that.focused !== item
 					&& that.focus(item) })
+		elem.addEventListener('contextmenu', 
+			function(evt){ 
+				evt.preventDefault()
+				that.menu(item) })
 		// user events...
 		Object.entries(item.events || {})
-			// shorthand events...
+			// shorthand DOM events...
 			.concat([
-					'click',
 				].map(function(evt){ 
 					return [evt, item[evt]] }))
 			// setup the handlers...
 			.forEach(function([evt, handler]){
 				handler
-					&& elem.addEventListener(evt, handler) })
+					&& elem.addEventListener(evt, handler.bind(that)) })
 
 		// buttons...
 		// XXX migrate the default buttons functionality and button inheritance...
@@ -3847,15 +3855,7 @@ var BrowserPrototype = {
 	keyPress: makeEventMethod('keypress', 
 		function(evt, key){
 			this.__keyboard_handler(key) }),
-	// XXX
-	menu: makeEventMethod('menu', function(){
-	}),
-	// XXX
-	copy: makeEventMethod('copy', function(){
-	}),
-	// XXX
-	paste: makeEventMethod('paste', function(){
-	}),
+	menu: makeItemEventMethod('menu'),
 
 
 	// Navigation...