mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-10-29 18:30:09 +00:00
notes...
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
cd559642f6
commit
fbebdd035f
@ -985,13 +985,21 @@ var CollectionActions = actions.Actions({
|
|||||||
d.collection = d.args[1] || this.collection
|
d.collection = d.args[1] || this.collection
|
||||||
},
|
},
|
||||||
// XXX this does not work yet...
|
// XXX this does not work yet...
|
||||||
// ...use .shiftImageTo(..)???
|
// ...need to trigger .reload(..), and considering that
|
||||||
|
// this is a UI action, doing so explicitly is logical...
|
||||||
|
// XXX can we unify .collect(..) and .addToCrop(..)???
|
||||||
|
// ...they essentially do the same thing with one exception
|
||||||
|
// a crop retains the full order while a collection has a
|
||||||
|
// cleared order...
|
||||||
|
// ..might also be a good idea to unify much of the
|
||||||
|
// collection and crop mechanics...
|
||||||
undo: function(d){
|
undo: function(d){
|
||||||
var that = this
|
var that = this
|
||||||
var gids = d.args[0] || [d.current]
|
var gids = d.args[0] || [d.current]
|
||||||
gids = gids instanceof Array ? gids : [gids]
|
gids = gids instanceof Array ? gids : [gids]
|
||||||
var collection = d.collection
|
var collection = d.collection
|
||||||
this
|
this
|
||||||
|
// XXX is this the right approach???
|
||||||
.collect(gids, collection)
|
.collect(gids, collection)
|
||||||
.ensureCollection(collection)
|
.ensureCollection(collection)
|
||||||
.then(function(){
|
.then(function(){
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user