flynx/diff.js
1
0
Fork 0
mirror of https://github.com/flynx/diff.js.git synced 2025-10-29 02:50:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2018-07-17 02:13:40 +03:00
parent 89098cb298
commit 9686f3f827
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
diff.js
View File

@ -111,6 +111,8 @@ var getCommonSections = function(A, B, cmp, min_chunk){
var l = chunk.length var l = chunk.length
while(a+l < A.length while(a+l < A.length
&& b+l < B.length && b+l < B.length
&& a+l in A
&& b+l in B
&& cmp(A[a+l], B[b+l])){ && cmp(A[a+l], B[b+l])){
l = chunk.length += 1 l = chunk.length += 1
} }
@ -391,16 +393,6 @@ Types.handle = function(type, obj, ...args){
// XXX check seen -- avoid recursion... // XXX check seen -- avoid recursion...
// XXX support Map(..) and other new-style types... // XXX support Map(..) and other new-style types...
// XXX TEST: the format should survive JSON.parse(JSON.stringify(..))... // XXX TEST: the format should survive JSON.parse(JSON.stringify(..))...
// XXX BUGS:
// _diff(new Array(1), [null | undefined])
// -> null, should be a change
// NOTE: passing a NaN will yield correct results...
// ...the problem is in getCommonSections(..) not
// distinguishing between null and empty...
// _diff(new Array(5), [])
// -> will only catch the length change...
// ...the problem is in getCommonSections(..) not
// distinguishing between null and empty...
var _diff = var _diff =
function(A, B, options, cache){ function(A, B, options, cache){
// XXX might be a god idea to mix in default options (different // XXX might be a god idea to mix in default options (different