From d45db4d848c36bd6f49b6e0d20be298b76dfe1a1 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Fri, 27 Jul 2018 16:32:26 +0300
Subject: [PATCH] notes...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 diff.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/diff.js b/diff.js
index a58bd28..5a7a309 100644
--- a/diff.js
+++ b/diff.js
@@ -736,6 +736,8 @@ module.Types = {
 		options.as_object = options.as_object || []
 
 		// basic compare...
+		// XXX nesting still does not work...
+		// 		diff(OR([1,2], [2,1]), [1,2]) -> false (should be true)
 		// XXX do we need to differentiate things like: new Number(123) vs. 123???
 		var bcmp = function(a, b, cmp){
 			return a === b 
@@ -746,10 +748,9 @@ module.Types = {
 				// logic patterns...
 				// XXX not final...
 				|| (a instanceof LogicType 
-					&& a.cmp(b, cmp))
+					&& a.cmp(b, cmp, cache))
 				|| (b instanceof LogicType 
-					&& b.cmp(a, cmp))
-		}
+					&& b.cmp(a, cmp, cache)) }
 		// deep compare...
 		var cmp = options.cmp = options.cmp 
 			|| function(a, b){