From e580ca99e78e66bc9cff36216e82d319d5e54048 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Fri, 18 Jun 2021 17:23:57 +0300
Subject: [PATCH] notes...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 diff2.js | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/diff2.js b/diff2.js
index 3c8962f..4865d7a 100644
--- a/diff2.js
+++ b/diff2.js
@@ -702,6 +702,7 @@ function(A, B, cmp){
 // 		...
 // 	]
 //
+// NOTE: this is generic -- does not care what it compares...
 var diffSections =
 module.diffSections =
 function(A, B, cmp){
@@ -726,9 +727,12 @@ function(A, B, cmp){
 			return gaps }, []) }	
 
 
-// XXX something about this is wrong...
-// 		...should return mirrored results from diffSections(..) but the 
-// 		results are very different...
+// XXX at this point array indexes are treated as changes, i.e. if we 
+// 		insert an item into an array, this effectively changes all other 
+// 		items (shifting their indexes by the number of items inserted)... 
+// 		...need to treat this gracefully...
+// 		......ignore array index???
+// 			...to do this we need to know object type per element compared...
 var diff =
 function(A, B){
 	return diffSections(
@@ -842,6 +846,7 @@ console.log('\n\n---\n',
 		)])
 
 
+/* XXX
 var A = ['x',1,2,3,1,2,3,4,5,,,4]
 var B = ['x',1,2,3,4,5,6]
 
@@ -858,6 +863,12 @@ console.log([...handle(B).chain(serializePaths)])
 
 // XXX
 console.log(diff(B, A))
+//*/
+
+console.log(JSON.stringify(diff(
+	[1,4,2,3],
+	[1,2,3],
+), null, '    '))