flynx/features.js
1
0
Fork 0
mirror of https://github.com/flynx/features.js.git synced 2025-10-29 10:20:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

added .feauteres.error.missing_suggested list...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-06-25 08:50:38 +03:00
parent 3e9576f4f7
commit a2b56d8b76
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
features.js
View File

@ -374,6 +374,8 @@ var FeatureSetProto = {
// }, // },
// } // }
// //
// XXX should exclusive conflicts resolve to first (current state)
// feature or last in an exclusive group???
buildFeatureList: function(lst, filter){ buildFeatureList: function(lst, filter){
var all = this.features var all = this.features
lst = (lst == null || lst == '*') ? all : lst lst = (lst == null || lst == '*') ? all : lst
@ -488,7 +490,12 @@ var FeatureSetProto = {
// directive gets disabled as a result // directive gets disabled as a result
// disabled - list of disabled features // disabled - list of disabled features
// missing - list of missing features // missing - list of missing features
// missing_suggested
// - list of missing suggested features and
// suggested feature dependencies
// exclusive - exclusive feature index // exclusive - exclusive feature index
// suggests - index of feature suggestions (full)
// suggested - suggested feature dependency index
// NOTE: the above containers will get updated as a side-effect. // NOTE: the above containers will get updated as a side-effect.
// NOTE: all of the above values are defined near the location // NOTE: all of the above values are defined near the location
// they are first used/initiated... // they are first used/initiated...
@ -516,7 +523,11 @@ var FeatureSetProto = {
// //
// NOTE: this stage does not track suggested feature dependencies... // NOTE: this stage does not track suggested feature dependencies...
// NOTE: we do not need loop detection active here... // NOTE: we do not need loop detection active here...
var s = expand('suggested', Object.keys(features), {}, { disabled: disabled }) var s = expand('suggested', Object.keys(features), {},
{
disabled: disabled,
missing: missing_suggested,
})
s = Object.keys(s) s = Object.keys(s)
.filter(function(f){ .filter(function(f){
// populate the tree of feature suggestions... // populate the tree of feature suggestions...
@ -531,6 +542,7 @@ var FeatureSetProto = {
disabled: disabled, disabled: disabled,
disable_loops: disable_loops, disable_loops: disable_loops,
exclusive: exclusive, exclusive: exclusive,
missing: missing_suggested,
}) })
Object.keys(s) Object.keys(s)
.forEach(function(f){ .forEach(function(f){
@ -555,7 +567,7 @@ var FeatureSetProto = {
var disable_loops = [] var disable_loops = []
var disabled = [] var disabled = []
var missing = [] var missing = []
// XXX var missing_suggested = []
var suggests = {} var suggests = {}
var suggested = {} var suggested = {}
@ -657,6 +669,7 @@ var FeatureSetProto = {
var excluded = [] var excluded = []
Object.keys(conflicts) Object.keys(conflicts)
.forEach(function(group){ .forEach(function(group){
// XXX should this resolve to the last of the first feature???
excluded = excluded.concat(conflicts[group].slice(1))}) excluded = excluded.concat(conflicts[group].slice(1))})
disabled = disabled.concat(excluded) disabled = disabled.concat(excluded)
@ -831,9 +844,11 @@ var FeatureSetProto = {
error: (loops.length > 0 error: (loops.length > 0
|| Object.keys(conflicts).length > 0 || Object.keys(conflicts).length > 0
|| loop_limit <= 0 || loop_limit <= 0
|| missing.length > 0) ? || missing.length > 0
|| missing_suggested.length > 0) ?
{ {
missing: missing, missing: missing,
missing_suggested: missing_suggested,
conflicts: conflicts, conflicts: conflicts,
// fatal stuff... // fatal stuff...

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "ig-features", "name": "ig-features",
"version": "3.1.6", "version": "3.1.7",
"description": "", "description": "",
"main": "features.js", "main": "features.js",
"scripts": { "scripts": {