From edcbd29087ef9d8a4fcffb1922be77aa4efae546 Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Sat, 10 Sep 2022 12:07:18 +0300 Subject: [PATCH] notes... Signed-off-by: Alex A. Naanou --- pwiki/store/base.js | 3 +++ pwiki2.js | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/pwiki/store/base.js b/pwiki/store/base.js index 2540745..3a8682e 100755 --- a/pwiki/store/base.js +++ b/pwiki/store/base.js @@ -454,6 +454,9 @@ module.BaseStore = { // this can be the result of matching a/* in a a/b/c // and returning a a/b which can be undefined... return that.get(p, strict) }) + // XXX BUG CHROME: this hangs on Chrome when getting a + // generator function... + // ...should not require any editing when bug fixed. : (await this.__get__(path) ?? ((this.next || {}).__get__ && this.next.get(path, strict))) }, diff --git a/pwiki2.js b/pwiki2.js index 8703f44..a3f24c4 100755 --- a/pwiki2.js +++ b/pwiki2.js @@ -2,12 +2,19 @@ * * * XXX BUG CHROME: can't .get(..) a generator... +* affected code: +* BaseStore's .get(..) +* bug report: * https://bugs.chromium.org/p/chromium/issues/detail?id=1361981 * when done test: * .get('/test/list/generator').asPages() * .get('/test/list/generator').raw * .get('/test/list/generator').data * .get('/test/list/generator').text +* potential temporaty fix: +* wrap all .__get__(..) call in an async function testing if +* it's return value is a generator function (return) or anything +* else (await)... * XXX CACHE need to explicitly prevent caching of some actions/pages... * XXX FEATURE tags and accompanying API... * - add tags to page -- macro/filter