From fa91636be5ba4775bc95feb3765ef7a97fab4f6a Mon Sep 17 00:00:00 2001 From: "Alex A. Naanou" Date: Thu, 22 Sep 2022 03:56:45 +0300 Subject: [PATCH] tweaks and notes... Signed-off-by: Alex A. Naanou --- pwiki/page.js | 6 +++--- pwiki/path.js | 8 ++++++-- pwiki2.js | 10 ++++++++++ 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/pwiki/page.js b/pwiki/page.js index 8d9a16a..1e558b2 100755 --- a/pwiki/page.js +++ b/pwiki/page.js @@ -1944,11 +1944,11 @@ module.System = { text: `@include("../**/path:@(all)" join="@source(line-separator)")`}, info: { text: object.doc` - Path: @source(../path) + Path: [@source(../path) ] (edit)
- Resolved path: @source(../resolved) + Resolved path: [@source(../resolved)] (edit)
- Referrer: @source(../referrer) + Referrer: [@source(../referrer)] (edit)
Args:
diff --git a/pwiki/path.js b/pwiki/path.js index f6c7c36..ae33b32 100755 --- a/pwiki/path.js +++ b/pwiki/path.js @@ -52,12 +52,16 @@ module = { // XXX EXPERIMENTAL encode: function(str){ return str - .replace(/[#:*%]/g, encodeURIComponent) }, + .replace(/[#:*%'"]/g, + function(s){ + return '%'+s.charCodeAt().toString(16) }) }, decode: function(str){ return decodeURIComponent(str) }, encodeElem: function(str){ return str - .replace(/[#:*%\\\/.]/g, encodeURIComponent) }, + .replace(/[#:*%'"\\\/]/g, + function(s){ + return '%'+s.charCodeAt().toString(16) }) }, decodeElem: function(str){ return decodeURIComponent(str) }, diff --git a/pwiki2.js b/pwiki2.js index d5489e2..dced3ce 100755 --- a/pwiki2.js +++ b/pwiki2.js @@ -6,6 +6,16 @@ * - fs store/export in browser or a simple way to export/import... * * +* XXX titles containing quotes break things... +* XXX BUG: for some reason deleting and refreshing takes ~2x as long as +* refreshing... +* to reproduce: +* pwiki.path = '/tree' // reports about ~2sec +* await pwiki.get('/Test/Subtree/Page2/delete').raw // refresh reports ~4sec (XXX) +* while: +* pwiki.path = '/tree' // reports about ~2sec +* await pwiki.get('/Test/Subtree/Page2').delete() // fast +* pwiki.path = '/tree' // reports about ~2sec * XXX macros: should we add the pattern path to .depends instead of the * final path... * ...would also need a fast way to pattern match...