From 0b4a7678ea5d01c117eb68b96c7f79e0245da6d6 Mon Sep 17 00:00:00 2001
From: "Alex A. Naanou" <alex.nanou@gmail.com>
Date: Fri, 13 Dec 2024 23:17:51 +0300
Subject: [PATCH] cleanup...

Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
---
 nextcloud/make.sh | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/nextcloud/make.sh b/nextcloud/make.sh
index 1af50c1..099c56c 100755
--- a/nextcloud/make.sh
+++ b/nextcloud/make.sh
@@ -153,11 +153,10 @@ pctPushAssets $ID
 # Colabora...
 if ! [ -z $COLLABORA_OFFICE ] ; then
 	echo "# Collabora office..."
-
-	# coolwsd...
-	# XXX still need to make this work through a reverse proxy...
 	# see:
 	# 	https://sdk.collaboraonline.com/docs/installation/Configuration.html
+
+	# coolwsd...
 	@ lxc-attach $ID -- bash -c "\
 		cd /usr/share/keyrings \
 			&& wget https://collaboraoffice.com/downloads/gpg/collaboraonline-release-keyring.gpg"
@@ -165,19 +164,17 @@ if ! [ -z $COLLABORA_OFFICE ] ; then
 		apt update \
 			&& apt install -y coolwsd code-brand"
 	# XXX should these be set in here or as args in the coolwsd.service ???
-	# /etc/coolwsd/coolwsd.xml
-	# XXX add groups...
-	# 	ssl>enable -> false
+	# ssl>enable -> false
 	@ lxc-attach $ID -- bash -c "\
 		sed -i \
 			'/<ssl /,+5{ s/\(<enable [^>]*>\)true\(<\/enable>\)/\1false\2/ }' \
 			/etc/coolwsd/coolwsd.xml"
-	# 	ssl>termination -> true
+	# ssl>termination -> true
 	@ lxc-attach $ID -- bash -c "\
 		sed -i \
 			'/<ssl /,+5{ s/\(<termination [^>]*>\)false\(<\/termination>\)/\1true\2/ }' \
 			/etc/coolwsd/coolwsd.xml"
-	# alias_groups...
+	# alias_groups -- allow access both from $APP_PASS and from LAN...
 	@ lxc-attach $ID -- bash -c "\
 		sed -i \
 			-e '/<alias_groups .* mode=\"first\"/ s/mode=\"first\"/mode=\"groups\"/ ' \