flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor stuff...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2017-05-09 04:32:42 +03:00
parent 46b7114062
commit 0cd4f3ab1a
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui (gen4)/features/meta.js
View File

@ -68,8 +68,8 @@ core.ImageGridFeatures.Feature('viewer-testing', [
//*/ //*/
// XXX EXPERIMENTAL: virtual-dom based ribbons... // XXX EXPERIMENTAL: virtual-dom based ribbons...
'ui-partial-ribbons-vdom', 'ui-partial-ribbons-vdom',
'-ui-image-marks', //'-ui-image-marks',
'-ui-image-bookmarks', //'-ui-image-bookmarks',
'-ui-partial-ribbons', '-ui-partial-ribbons',
'-ui-partial-ribbons-2', '-ui-partial-ribbons-2',
//*/ //*/

8
ui (gen4)/features/ui-partial-ribbons-vdom.js
View File

@ -489,14 +489,13 @@ object.makeConstructor('VirtualDOMRibbons',
// - image update (try and avoid external edits and do it in .virtualdom) // - image update (try and avoid external edits and do it in .virtualdom)
// - image size/proportions (single image view)... // - image size/proportions (single image view)...
// - preview update... // - preview update...
// - marking
// - shifting images/ribbons // - shifting images/ribbons
// - use .virtualdom.sync() + shadow animation instead of .ribbons.* // - use .virtualdom.sync() + shadow animation instead of .ribbons.*
// ...the added marker div messes up virtual-dom... // ...the added marker div messes up virtual-dom...
// - would be nice to make this an alternative feature... // - would be nice to make this an alternative feature...
// ...split out ribbon editing into a feature and do two // ...split out ribbon editing into a feature and do two
// implementations, the original and virtualdom... // implementations, the original and virtualdom...
// // - ranges and make marks more modular...
// //
var PartialRibbonsActions = actions.Actions({ var PartialRibbonsActions = actions.Actions({
@ -559,6 +558,11 @@ module.PartialRibbons = core.ImageGridFeatures.Feature({
exclusive: ['ui-partial-ribbons'], exclusive: ['ui-partial-ribbons'],
depends: [ depends: [
'ui', 'ui',
// disabled stuff...
// XXX is this the right spot for these...
'-ui-image-marks',
'-ui-image-bookmarks',
], ],
suggested: [ suggested: [
'ui-partial-ribbons-precache', 'ui-partial-ribbons-precache',