flynx/ImageGrid
1
1
Fork 0
mirror of https://github.com/flynx/ImageGrid.git synced 2025-10-29 18:30:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

tweaks...

Browse Source 
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
Alex A. Naanou 2019-12-10 15:09:25 +03:00
parent 5d1c53593c
commit 15bbce5162
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ui (gen4)/features/ui-widgets.js
View File

@ -1021,6 +1021,13 @@ browse.items.makeSubContext = function(name, obj){
// XXX EXPERIMENT... // XXX EXPERIMENT...
// XXX Q: should we add an ImageGrid context to make(..)??? // XXX Q: should we add an ImageGrid context to make(..)???
// ...something like .app for making it generic-ish for example... // ...something like .app for making it generic-ish for example...
// ....a different approach to this would be to create a list editor
// within the current dialog independently of the outer context...
// ...this could either be done as:
// - a popup/modal sub dialog
// ...this can be problematic as the wrapper is external to the browser...
// - as a sub-path...
// ...this is hard without side-effects...
// XXX Q: do we actually need .Field(..), it does everything make(..) // XXX Q: do we actually need .Field(..), it does everything make(..)
// does already??? // does already???
// XXX Q: should title/value args be optional??? // XXX Q: should title/value args be optional???
@ -1046,9 +1053,8 @@ browse.items.makeSubContext('field',
// //
// .field.Toggle(title, value) // .field.Toggle(title, value[, options])
// .field.Toggle(title, options) // .field.Toggle(title, options)
// .field.Toggle(title, value, options)
// //
// XXX need to open a list dialog (currently context is used)... // XXX need to open a list dialog (currently context is used)...
// ...this can be set via options.list but would be nice to provide // ...this can be set via options.list but would be nice to provide
@ -1074,6 +1080,9 @@ function(title, options){
type: 'toggle', type: 'toggle',
open: function(evt){ open: function(evt){
// XXX
//var actions = options.app || that.app
var getValues = function(){ var getValues = function(){
return options.values instanceof Function ? return options.values instanceof Function ?
options.values.call(actions) options.values.call(actions)
@ -1167,6 +1176,9 @@ function(title, options){
options options
// normalize value... // normalize value...
.run(function(){ .run(function(){
// XXX
//var actions = options.app || that.app
if(!(this.value instanceof Function)){ if(!(this.value instanceof Function)){
var values = options.values instanceof Function ? var values = options.values instanceof Function ?
options.values.call(actions) options.values.call(actions)