mirror of
https://github.com/flynx/ImageGrid.git
synced 2025-10-29 18:30:09 +00:00
minor cleanup..
Signed-off-by: Alex A. Naanou <alex.nanou@gmail.com>
This commit is contained in:
parent
bc9962bc64
commit
2e81b0407e
@ -30,7 +30,8 @@
|
||||
* XXX should this serialize recursively down???
|
||||
* ...it might be a good idea to decide on a serialization
|
||||
* protocol and use it throughout...
|
||||
* XXX should .tags() return all the used tags + .persistent or .persistentAll ???
|
||||
* XXX should .tags() return all the used tags + .persistent or
|
||||
* .persistentAll ???
|
||||
*
|
||||
*
|
||||
*
|
||||
@ -53,6 +54,8 @@ var util = require('lib/util')
|
||||
// .someMethod(arg, ..)
|
||||
// .someMethod([arg, ..])
|
||||
//
|
||||
//
|
||||
// XXX better docs -- signature...
|
||||
var normalizeSplit = function(args){
|
||||
return (args.length == 1 && args[0] instanceof Array) ?
|
||||
args.pop()
|
||||
@ -968,7 +971,6 @@ var BaseTagsPrototype = {
|
||||
//
|
||||
// XXX need to sanitize tag -- it can not contain regex characters...
|
||||
// ...should we guard against this???
|
||||
// XXX should both sides of the definition be renamed???
|
||||
rename: function(tag, to, ...tags){
|
||||
var that = this
|
||||
|
||||
@ -1172,10 +1174,6 @@ var BaseTagsPrototype = {
|
||||
// NOTE: this will also clear the index...
|
||||
this.define(tag, null)
|
||||
|
||||
// XXX add the def...
|
||||
//this.definitions = (this.definitions || new Set())
|
||||
// .add(value +'/'+ tag)
|
||||
|
||||
// update the index...
|
||||
this.definitions = definitions || {}
|
||||
this.definitions[tag] = this.splitSet(value)
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user