Merge branch 'master' of github.com:flynx/ImageGrid

This commit is contained in:
Alex A. Naanou 2021-01-18 01:08:30 +03:00
commit a6dac37f01
2 changed files with 2 additions and 6 deletions

View File

@ -2725,7 +2725,8 @@ function(title, func){
// //
// XXX might be a good idea to split this into a generic and domain parts // XXX might be a good idea to split this into a generic and domain parts
// and move the generic part into types/runner... // and move the generic part into types/runner...
// XXX check if item is already in queue... // XXX check if item is already in queue (???)
// ...how do we identify item uniqueness??
var queueHandler = var queueHandler =
module.queueHandler = module.queueHandler =
function(title, func){ function(title, func){

View File

@ -422,7 +422,6 @@ var SharpActions = actions.Actions({
// XXX should we split this into a session and global versions // XXX should we split this into a session and global versions
// a-la .makeResizedImage(..)??? // a-la .makeResizedImage(..)???
// XXX this does not update image.base_path -- is this correct??? // XXX this does not update image.base_path -- is this correct???
// XXX add support for offloading the processing to a thread/worker...
// XXX make index dir hidden... // XXX make index dir hidden...
makePreviews: ['Sharp|File/Make image $previews', makePreviews: ['Sharp|File/Make image $previews',
core.doc`Make image previews core.doc`Make image previews
@ -700,10 +699,6 @@ var SharpActions = actions.Actions({
&& logger.emit('skipped', `${gid} / ${size}`) && logger.emit('skipped', `${gid} / ${size}`)
}) })) })], }) })) })],
// XXX BUG: .cacheMetadata('all'): runs out of call stack on very
// large indexes...
// ...can't yet see/find any recursion...
// .....at least the fail is fast and quiet =)
// XXX add support for offloading the processing to a thread/worker... // XXX add support for offloading the processing to a thread/worker...
// XXX revise logging and logger passing... // XXX revise logging and logger passing...
cacheMetadata: ['- Sharp|Image/', cacheMetadata: ['- Sharp|Image/',